home *** CD-ROM | disk | FTP | other *** search
- Path: sparky!uunet!zaphod.mps.ohio-state.edu!darwin.sura.net!spool.mu.edu!agate!stanford.edu!apple!cambridge.apple.com!goofy!mumbo.apple.com!gallant.apple.com!news
- From: neumann.m@applelink.apple.com (mark neumann)
- Newsgroups: comp.software-eng
- Subject: Software Inspections. How many does it take?
- Message-ID: <1992Dec14.192008.15480@gallant.apple.com>
- Date: 14 Dec 92 19:20:08 GMT
- Sender: news@gallant.apple.com
- Organization: HomePro Computer Services
- Lines: 48
-
- Recently I have been reading Capers Jones new book "Applied Software
- Measurement", McGraw Hill. There is a lot of good stuff in it, but one
- recommendation he makes on the topic of software inspections does not
- match my experience.
-
- He presents some statistics showing software inspections (design reviews,
- code walkthroughs, etc..) as being the most effective way of removing
- defects. However, the inspection technique he describes requires a
- bunch of people! (he lists the following staff as being present):
-
- " * A moderator (to keep discussions within bounds)
- * A reader (to paraphase the work being inspected)
- * A recorder (to keep records of all defects)
- * An inspector (to identify any problems)
- * An author (whose work is being inspected)
-
- All five (or more) may be present for large projects. For small projects
- dual roles can be assigned, so that the minimum number for a true
- inspection is three: moderator, author, and one other person. "
-
- For high-level architecture/design approach type reviews, everyone
- affected needs to be involved. But what about module level design/code
- inspections, where the work being inspected is the result of one persons
- effort?
-
- In my experience, when the schedule pressure is on, most of the attendees
- at large formal code walkthroughs are too busy with their own work to
- carefully go over the material being reviewed. This diminishes the
- effectiveness of the review.
-
- It seems obvious that having someone check your work is a good idea. It
- also seems that each additional person that checks your work is less
- likely to find a problem (on average).
-
- My question: Is one person enough? Does anybody else use a single
- reviewer approach?
-
- I believe that there are interpersonal dynamics which make one reviewer
- more effective than two of more. With two or more people, the ego of the
- person whose work is being reviewed is more likely to become a factor.
-
- Finally, by assigning a single reviewer to inspect someone elses work,
- that person is obviously responsible for any flaws that get through, so
- he/she is likely to take the role seriously. (Note: you probably do not
- want to assign people to inspect each other's work, since they may agree
- to just trust each other completely).
- --------------------------------------------
- Opinions expressed are solely my own.
-