home *** CD-ROM | disk | FTP | other *** search
/ NetNews Usenet Archive 1992 #26 / NN_1992_26.iso / spool / gnu / utils / bug / 1986 < prev    next >
Encoding:
Text File  |  1992-11-07  |  2.0 KB  |  61 lines
  1. Newsgroups: gnu.utils.bug
  2. Path: sparky!uunet!charon.amdahl.com!pacbell.com!decwrl!ames!agate!usenet.ins.cwru.edu!magnus.acs.ohio-state.edu!cis.ohio-state.edu!ced.berkeley.edu!jeg
  3. From: jeg@ced.berkeley.edu (James Ganong)
  4. Subject: suggestion for confusing messages from tar-1.11.1
  5. Message-ID: <9211052113.AA29206@ced.berkeley.edu>
  6. Sender: gnulists@ai.mit.edu
  7. Organization: GNUs Not Usenet
  8. Distribution: gnu
  9. Date: Thu, 5 Nov 1992 21:13:41 GMT
  10. Approved: bug-gnu-utils@prep.ai.mit.edu
  11. Lines: 48
  12.  
  13. i think the messages that tar spits out with -v and -g are confusing.
  14. here is my suggestion
  15.  
  16.  
  17. the following part of gnu.c looks to see if it has seen a directory's
  18. name before, and if its inode as changed.
  19.  
  20.  
  21.                                 if(dp=get_dir(namebuf)) {
  22.                                         if(   dp->dev!=hs.st_dev
  23.                                            || dp->ino!=hs.st_ino) {
  24.                                                 if(f_verbose)
  25.                                                         msg("directory %s has be
  26. en renamed.",namebuf);
  27.                                                 dp->allnew=1;
  28.                                                 dp->dev=hs.st_dev;
  29.                                                 dp->ino=hs.st_ino;
  30.                                         }
  31.                                         dp->dir_text="";
  32.                                 } else {
  33.                                         if(f_verbose)
  34.                                                 msg("Directory %s is new",namebu
  35.  
  36. % mkdir e/e
  37. % ./tar -cvf /dev/null -g r e
  38. ./tar: Directory e/e is    new
  39. e/
  40. e/e/
  41. % mv e/e e/f
  42. % ./tar -cvf /dev/null -g r e
  43. ./tar: Directory e/f is    new
  44. e/
  45. e/f/
  46. % mkdir e/e
  47. % rmdir e/f
  48. % mv e/e e/f
  49. % !.
  50. ./tar -cvf /dev/null -g    r e
  51. ./tar: directory e/f has been renamed.
  52. e/
  53. e/f/
  54.  
  55. I think that instead of "directory %s has been renamed" it should say
  56. "directory %s is a new directory reusing an old directory name"
  57.  
  58. and instead of "Directory %s is new" it should say
  59. "Directory %s is a new directory name"
  60.  
  61.