Problem: 1382334

Title: Inconsistency in MacApp.h

Received: Aug 26 1996 3:47PM


I think there is a (inconsitency) bug in MacApp.h (see below). In MacApp.h, the comment indicates that include conditionalMacros.h before any other headers. The related sections from the following two files are included. If we include Conditional.h before we call MacApp, we would get the error message shown at the end of these 2 files.

For instance, if we have the following "include"s ...

#include  -- This one includes  which includes
                            
#include 
#include 
#include 
#include 
#include "MOOF.h"  -- This one includes  which includes
                        
-----------------------------------------------------------------
// MacApp.h
// Copyright © 1984-96 by Apple Computer, Inc. All rights reserved.
// Core MacApp header files.
#ifndef __MACAPP__
#define __MACAPP__
// Conditional Macros (include before any other headers)
#ifndef __MACONDITIONALMACROS__
#include "MAConditionalMacros.h"
#endif
.....
......
----------------------------------------------------------------
// MAConditionalMacros.h
// Copyright © 1984-96 by Apple Computer, Inc. All rights reserved.
// MacApp 3.5 version
#if !defined(__MACONDITIONALMACROS__)
#define __MACONDITIONALMACROS__
#if defined(__CONDITIONALMACROS__)
#	error "MAConditionalMacros.h must be included first."
#endif
....
.......
----------------------------------------------
ERROR MESSAGE .........
C++ Compiler 8.1.0 Copyright (C) 1985-1996 by Symantec Corporation
   (written by Walter Bright, adapted to the 68000 by Symantec)
File "Macintosh HD:MPW:MacApp Rel.10:Libraries:Core:Includes:
MAConditionalMacros.h"; line 10 
#Error: "MAConditionalMacros.h must be included first."
#-----------------------
If we include "Moof.h" before  we would get the 
following error messages. 
{
^
File "Finder.h"; line 13 #Error: undefined identifier 'TDialogView'
#-----------------------
	virtual pascal void		DoPostCreate (TDocument* );
	                   		                      ^
File "Finder.h"; line 17 #Error: parameter list is out of context
#-----------------------
	virtual void			GetLabelForColumn (short i, CStr255& text);
	            			                                  ^
File "Finder.h"; line 27 #Error: ')' expected
#-----------------------
	FInfo							ioFlFndrInfo;
	     							           ^
File "Macintosh HD:MPW:Interfaces:CIncludes:Files.h"; line 323 #Error: ';' expected
#-----------------------
	FInfo							ioFlFndrInfo;
	     							           ^
File "Macintosh HD:MPW:Interfaces:CIncludes:Files.h"; line 437 #Error: ';' expected
#-----------------------
Fatal error: too many errors
Do I overlook anything? Please let me know if you find the same bug?
Fix:

Changed comment to match up with new MacAppRequired.h.